It would be nice to have wrap the exceptions so that when things blow up, the user gets a nicer error messages.
http://gwt-code-reviews.appspot.com/1195801/diff/1/10 File user/src/com/google/gwt/media/dom/client/MediaElement.java (right): http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode452 user/src/com/google/gwt/media/dom/client/MediaElement.java:452: * On 2010/12/10 16:07:07, rice wrote:
Where do you see this restriction in the spec?
On 2010/12/09 17:01:09, pdr wrote: > Note that is should be a positive integer between 0.0 and 1.0. (Or,
is
negative > allowed?)
It doesn't appear in the spec and I shouldn't have added that note. http://gwt-code-reviews.appspot.com/1195801/diff/3001/4007 File user/src/com/google/gwt/media/client/Audio.java (right): http://gwt-code-reviews.appspot.com/1195801/diff/3001/4007#newcode43 user/src/com/google/gwt/media/client/Audio.java:43: return !!$doc.createElement('audio').getContext; This doesn't work. Replace with: return !!$doc.createElement('audio').canPlayType; http://gwt-code-reviews.appspot.com/1195801/diff/3001/4008 File user/src/com/google/gwt/media/client/Video.java (right): http://gwt-code-reviews.appspot.com/1195801/diff/3001/4008#newcode43 user/src/com/google/gwt/media/client/Video.java:43: return !!$doc.createElement('video').getContext; This doesn't work. Replace with: return !!$doc.createElement('video').canPlayType; http://gwt-code-reviews.appspot.com/1195801/diff/3001/4008#newcode50 user/src/com/google/gwt/media/client/Video.java:50: setElement(Document.get().createVideoElement()); Forgot to include your changes in Document.java in this review (createVideoElement() and createAudioElement()). http://gwt-code-reviews.appspot.com/1195801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
