http://gwt-code-reviews.appspot.com/1195801/diff/1/10 File user/src/com/google/gwt/media/dom/client/MediaElement.java (right):
http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode119 user/src/com/google/gwt/media/dom/client/MediaElement.java:119: * source have been buffered locally. Not all browsers support this feature. On 2010/12/09 17:01:09, pdr wrote:
Can this be made explicit? Which browsers?
I'm removing the text -- eventually this should be covered by release notes or class comments http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode130 user/src/com/google/gwt/media/dom/client/MediaElement.java:130: * @return a String URL On 2010/12/09 17:01:09, pdr wrote:
@return a String URL, or the empty string if there is no source
Fixed http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode139 user/src/com/google/gwt/media/dom/client/MediaElement.java:139: * @return the time as a double On 2010/12/09 17:01:09, pdr wrote:
@return the time, in seconds, as a double
Fixed http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode156 user/src/com/google/gwt/media/dom/client/MediaElement.java:156: return this.defaultPlaybackRate || 1.0; On 2010/12/09 17:01:09, pdr wrote:
Could the "|| 1.0" cause a defaultPlaybackRate of 0 to return 1.0?
(Here, and
elsewhere in this file.)
Fixed http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode184 user/src/com/google/gwt/media/dom/client/MediaElement.java:184: * @return the initial time, or 0.0 if it has not been set On 2010/12/09 17:01:09, pdr wrote:
Is it 0.0 for not-yet set, or for unknown?
Unknown, fixed http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode220 user/src/com/google/gwt/media/dom/client/MediaElement.java:220: * source have been played. Not all browsers support this feature. On 2010/12/09 17:01:09, pdr wrote:
Can this be made explicit? Which browsers?
I'm removing the text -- eventually this should be covered by release notes or class comments http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode264 user/src/com/google/gwt/media/dom/client/MediaElement.java:264: * source are seekable. Not all browsers support this feature. On 2010/12/09 17:01:09, pdr wrote:
Can this be made explicit? Which browsers?
I'm removing the text -- eventually this should be covered by release notes or class comments http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode395 user/src/com/google/gwt/media/dom/client/MediaElement.java:395: * Causes the resource to be loaded. You don't need to call it when you change the src attribute, but you would call it if you made a change to a <source> element that is a child of the <audio> or <video> element. I'll add <source> elements in a future CL. On 2010/12/09 17:01:09, pdr wrote:
Can you javadoc when this should be used? From my reading of the spec,
it's for
when the user sets the source attribute, but is done automatically
upon setting
the src attribute?
http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode440 user/src/com/google/gwt/media/dom/client/MediaElement.java:440: * @param time a number within the ranges given by {...@link #getSeekable() On 2010/12/09 17:01:09, pdr wrote:
Is this unit in seconds?
Yes, fixed http://gwt-code-reviews.appspot.com/1195801/diff/1/10#newcode452 user/src/com/google/gwt/media/dom/client/MediaElement.java:452: * Where do you see this restriction in the spec? On 2010/12/09 17:01:09, pdr wrote:
Note that is should be a positive integer between 0.0 and 1.0. (Or, is
negative
allowed?)
http://gwt-code-reviews.appspot.com/1195801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
