Also, bunch of space-erasure going on.

http://gwt-code-reviews.appspot.com/1268801/diff/1/2
File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right):

http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode24
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:24: * Returns
this type with no type annotations or type variables.
This seems kind of unclear.

http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode44
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:44: * > Java
Language Spec, Edition 2</a>.
Seems a negative reformat.

http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode55
dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:55: * Returns
the name of this class without the package name.
Some clarification is needed for what happens to nested types.

http://gwt-code-reviews.appspot.com/1268801/diff/1/3
File dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java
(right):

http://gwt-code-reviews.appspot.com/1268801/diff/1/3#newcode50
dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java:50: *
comment metadata from the source.
The last part is no longer true.

http://gwt-code-reviews.appspot.com/1268801/show

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to