Updated Patch
http://gwt-code-reviews.appspot.com/1268801/diff/1/2 File dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java (right): http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode24 dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:24: * Returns this type with no type annotations or type variables. On 2011/01/07 22:03:28, scottb wrote:
This seems kind of unclear.
Updated. Honestly, I'm at a loss as to how to describe the difference between a JRawType and getErasedType. I can see how they are different in implementation, but it looks to me like two different developers trying to do something similar. http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode29 dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:29: * Returns the equivalent of {...@link Class#getName()} if the type were loaded. On 2011/01/07 22:26:45, tobyr wrote:
This isn't true as far as I know. I believe this always returns the
"field
descriptor" for a type. See JVMS 4.3. I think we should javadoc it as
such.
Adding a couple of examples may not hurt: String.class =>
"Ljava/lang/String;".
boolean.class => "Z"
Done. http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode44 dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:44: * > Java Language Spec, Edition 2</a>. On 2011/01/07 22:03:28, scottb wrote:
Seems a negative reformat.
Done. http://gwt-code-reviews.appspot.com/1268801/diff/1/2#newcode55 dev/core/src/com/google/gwt/core/ext/typeinfo/JType.java:55: * Returns the name of this class without the package name. On 2011/01/07 22:03:28, scottb wrote:
Some clarification is needed for what happens to nested types.
Based on reading the code - it appears the enclosing type names are stripped. http://gwt-code-reviews.appspot.com/1268801/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java (right): http://gwt-code-reviews.appspot.com/1268801/diff/1/3#newcode50 dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java:50: * comment metadata from the source. On 2011/01/07 22:03:28, scottb wrote:
The last part is no longer true.
Done. http://gwt-code-reviews.appspot.com/1268801/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
