http://gwt-code-reviews.appspot.com/1329802/diff/1/2 File dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java (right):
http://gwt-code-reviews.appspot.com/1329802/diff/1/2#newcode1 dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:1: package com.google.gwt.dev.javac; Need header comment. http://gwt-code-reviews.appspot.com/1329802/diff/1/2#newcode9 dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:9: public class CachedCompilationUnit extends CompilationUnitImpl { Implements serializable? http://gwt-code-reviews.appspot.com/1329802/diff/1/2#newcode11 dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:11: final ContentId contentId; private? http://gwt-code-reviews.appspot.com/1329802/diff/1/2#newcode64 dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:64: } readResolve to call initUnit(this) on enclosed classes? Or is the plan to only lazily load/deserialize classes? http://gwt-code-reviews.appspot.com/1329802/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right): http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode19 dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:19: import com.google.gwt.dev.util.StringInterner; Strange sort order. http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode64 dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:64: private final String binaryName; Please don't change this terminology. Binary name generally means something like "com.google.Foo$Impl" whereas internal name means "com/google/Foo$Impl". http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode76 dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:76: */ nameEnvironmentAnswer is just a cached thing that can be recreated, but I do wonder how the unit gets setup. http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode177 dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:177: int length = inputStream.readInt(); Just use "token = diskCache.transferFromStream(stream);" (See SyntheticArtifact.readObject). http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode185 dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:185: byte[] byteCode = diskCache.readByteArray(cacheToken); Just use "diskCache.transferToStream(token, stream);" (See SyntheticArtifact.writeObject). http://gwt-code-reviews.appspot.com/1329802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
