updated patch
http://gwt-code-reviews.appspot.com/1329802/diff/1/2 File dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java (right): http://gwt-code-reviews.appspot.com/1329802/diff/1/2#newcode1 dev/core/src/com/google/gwt/dev/javac/CachedCompilationUnit.java:1: package com.google.gwt.dev.javac; On 2011/02/05 00:09:44, scottb wrote:
Need header comment.
Oops, this file snuck in by mistake. http://gwt-code-reviews.appspot.com/1329802/diff/1/3 File dev/core/src/com/google/gwt/dev/javac/CompiledClass.java (right): http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode64 dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:64: private final String binaryName; On 2011/02/05 00:09:44, scottb wrote:
Please don't change this terminology. Binary name generally means
something
like "com.google.Foo$Impl" whereas internal name means
"com/google/Foo$Impl". Done. http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode76 dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:76: */ On 2011/02/05 00:09:44, scottb wrote:
nameEnvironmentAnswer is just a cached thing that can be recreated,
but I do
wonder how the unit gets setup.
Yes, I was thinking that initUnit would need to be called to re-initialize the unit variable. I was considering CompiledClass in a vacuum. Removed transient to just let Java do its thing. http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode102 dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:102: CompiledClass(ClassFile classFile, CompiledClass enclosingClass) { I moved this constructor logic all into JdtCompiler. http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode177 dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:177: int length = inputStream.readInt(); On 2011/02/05 00:09:44, scottb wrote:
Just use "token = diskCache.transferFromStream(stream);"
(See SyntheticArtifact.readObject).
Done. http://gwt-code-reviews.appspot.com/1329802/diff/1/3#newcode185 dev/core/src/com/google/gwt/dev/javac/CompiledClass.java:185: byte[] byteCode = diskCache.readByteArray(cacheToken); On 2011/02/05 00:09:44, scottb wrote:
Just use "diskCache.transferToStream(token, stream);"
(See SyntheticArtifact.writeObject).
Done. http://gwt-code-reviews.appspot.com/1329802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
