LGTM
http://gwt-code-reviews.appspot.com/1329802/diff/1004/6 File dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java (right): http://gwt-code-reviews.appspot.com/1329802/diff/1004/6#newcode267 dev/core/src/com/google/gwt/dev/javac/JdtCompiler.java:267: String internalName = CharOperation.charToString(binding.constantPoolName()); Funny, but I was playing with this exact code for a different reason, and ClassFile.fileName()) actually gives the right answer, too. http://gwt-code-reviews.appspot.com/1329802/diff/1004/7 File dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java (right): http://gwt-code-reviews.appspot.com/1329802/diff/1004/7#newcode33 dev/core/test/com/google/gwt/dev/javac/CompiledClassTest.java:33: File f = File.createTempFile("tCCS", ".object"); Delete on exit? Actually, the test is probably cleaner if you just write/read with BAOS/BAIS and don't hit the disk at all, it's just an unnecessary failure point. http://gwt-code-reviews.appspot.com/1329802/show -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
