Chris, the problem Eric is trying to address here is that you are not
always guaranteed to get the shutdown sequence cleanly when you quit the
app, so this helps insure that data will be written out.

Although, I'm wondering if 10 seconds is too long, Eric, how about 5
seconds?


http://gwt-code-reviews.appspot.com/1361801/diff/1/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):

http://gwt-code-reviews.appspot.com/1361801/diff/1/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java#newcode352
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:352:
public void run() {
Might it be a bit cleaner, to use a java.util.Timer, and have it
periodically call flush()?  This way, there's no separation between the
flush mechanism that's there, and this new auto-flush feature. (In
looking at it, might need to make the flushLatch thread conscious, a
separate issue here).

http://gwt-code-reviews.appspot.com/1361801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to