[gwt-contrib] Re: Adds a 10 second flush timer to the Speed Tracer logger. (issue1361801)

[scottb]

http://gwt-code-reviews.appspot.com/1361801/diff/1/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):

http://gwt-code-reviews.appspot.com/1361801/diff/1/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java#newcode364
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:364:
}
On 2011/02/23 19:08:12, scottb wrote:

Total matter of opinion, but seems slightly easier to follow if the

thing you

track is "nextFlush" ala:

long nextFlush = lastFlush + FLUSH_TIMER_MSECS;
poll(nextFlush - System.CTM()) // okay to be negative?
if (System.CTM() >= nextFlush) { ... }

Come to think of it, you wouldn't need to track lastFlush.

http://gwt-code-reviews.appspot.com/1361801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors