On 2011/02/23 18:28:33, zundel wrote:
@jbrosenberg: the existing flush mechanism is meant pretty much just
for
unit tests (package protected method flush()).  It has extra tooling
to
communicate from one thread over to the background thread.  To
implement a
10 second flush in the writer thread, there is no need to synchronize
between threads and block the sender thread the way that
SpeedTracerLogger.flush() does.


Eric, agreed, no need for the extra synchronization there in the default
flush() method, so maybe it could be a flushAsync() method, which
doesn't do a flushLatch.await(), but nonetheless does enqueue the
flushSentinel.


http://gwt-code-reviews.appspot.com/1361801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to