On 2011/02/23 21:05:48, zundel wrote:
http://gwt-code-reviews.appspot.com/1361801/diff/7001/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
File
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java
(right):
http://gwt-code-reviews.appspot.com/1361801/diff/7001/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java#newcode357
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:357:
threadEventQueue.poll(nextFlush - System.currentTimeMillis(),
On 2011/02/23 20:23:10, conroy wrote:
> can this safely go negative? the javadoc doesn't specify the
behavior in that
> case.
It doesn't say, but peeking at the implementation of poll(), it
immediately
returns null if the timeout value is <= 0. I'm pretty comfortable
with just
assuming poll() will always behave like that because barring an
Exception (which
isn't documented either) I can't think of another behavior that makes
any sense.
http://gwt-code-reviews.appspot.com/1361801/diff/7001/dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java#newcode371
dev/core/src/com/google/gwt/dev/util/log/speedtracer/SpeedTracerLogger.java:371:
if (System.currentTimeMillis() > nextFlush) {
On 2011/02/23 20:23:10, conroy wrote:
> make this >=
Done.
LGTM.
http://gwt-code-reviews.appspot.com/1361801/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
