You'll want to revert your diff-cheese anyhow before committing, but
yes, that help.

LG except for TypeOracle hack.  Just make your tests use the correct
FQTN for JavaScriptObject.


http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java
File dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java
(right):

http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java#newcode156
dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java:156: *
@param className Overrides the fullly qualified class name for
JavaScriptObject.
fully

http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java
File
dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java
(right):

http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java#newcode599
dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:599:
protected static final CheckedJavaResource CU_JavaScriptObject = new
CheckedJavaResource(
With a little kung-fu, you could make the fully-qualified type name here
be the same as the REAL JavaScriptObject FQTN, and thus avoid the
egregious for-testing hackery in TypeOracle.

http://gwt-code-reviews.appspot.com/1369805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to