On Thu, Mar 3, 2011 at 1:47 PM, <[email protected]> wrote:

>
>
> http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java
> File
> dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java
> (right):
>
>
> http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java#newcode218
> dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:218:
> null, getByteCode(aClass), System.currentTimeMillis());
> On 2011/03/03 17:36:26, zundel wrote:
>
>> On 2011/03/03 17:14:07, scottb wrote:
>> > Unrelated, but shouldn't this be getLastModified() instead of
>>
> current time?
>
>  I dunno, do you want it to use caching?
>>
>
> Its intended to represent the timestamp of the source file or class file
> resource as you mention, but in order to compute dependency between
> types at the type oracle level.  The idea is to use it for determining
> when to re-run generators or to use the cache of the previous generator
> run.
>
> I figured for unit testing we would want to invalidate any previous
> cache.


Ahh, gotcha.  Mind throwing a comment there while you're in there?

-- 
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to