updated patch
http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java File dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java (right): http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java#newcode156 dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java:156: * @param className Overrides the fullly qualified class name for JavaScriptObject. On 2011/03/03 00:12:08, scottb wrote:
fully
Done. http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java#newcode159 dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java:159: jsoClassName = className; On 2011/03/02 23:01:59, jaimeyap wrote:
This worries me a little bit :).
Can we make this protected or package protected?
I created a TypeOracleDelegate class and changed the method to package protected in typemodel.TypeOracle. I think its a bit awkward, but it hides it from rogue Generator developers. http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java#newcode941 dev/core/src/com/google/gwt/dev/javac/typemodel/TypeOracle.java:941: On 2011/03/02 23:01:59, jaimeyap wrote:
whitespace
Done. http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java File dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java (right): http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java#newcode599 dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:599: protected static final CheckedJavaResource CU_JavaScriptObject = new CheckedJavaResource( On 2011/03/03 00:12:08, scottb wrote:
With a little kung-fu, you could make the fully-qualified type name
here be the
same as the REAL JavaScriptObject FQTN, and thus avoid the egregious
for-testing
hackery in TypeOracle.
I tried, but my kung-fu wasn't good enough. The Byte code test needs byte code. We use reflection to get it from a class instance. But JavaScriptObject.java isn't a part of the gwt-dev project, so JavaScriptObject.class it isn't resolved when I tried using it. I suppose we could hack up and build.xml files and eclipse projects and try to get JavaScriptObject referenced by gwt-dev, but that seems like a lot of work. Did you having something else in mind? http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java#newcode648 dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:648: }; On 2011/03/02 23:01:59, jaimeyap wrote:
insert newline
Done. http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java#newcode660 dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:660: }; On 2011/03/02 23:01:59, jaimeyap wrote:
newline
Done. http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java#newcode669 dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:669: }; On 2011/03/02 23:01:59, jaimeyap wrote:
newline
Done. http://gwt-code-reviews.appspot.com/1369805/diff/3001/dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java#newcode678 dev/core/test/com/google/gwt/dev/javac/TypeOracleMediatorTestBase.java:678: }; On 2011/03/02 23:01:59, jaimeyap wrote:
newline
Done. http://gwt-code-reviews.appspot.com/1369805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
