I agree with making PUC non-static. This reduces the need to synchronize on getting instance, etc.
http://gwt-code-reviews.appspot.com/1375802/diff/5002/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java File dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java (right): http://gwt-code-reviews.appspot.com/1375802/diff/5002/dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java#newcode110 dev/core/src/com/google/gwt/dev/javac/PersistentUnitCache.java:110: unitCacheLoaderThread.start(); Fair enough. I guess I was thinking (without actually articulating) that we could have a TPE available as a service for DevMode thread tasks. This would allow control of threading in the app overall, etc. TPE allows scheduling at regular intervals, etc., such for cleaning up directories, or polling a work queue, etc. This would make it very trivial to say, make the adding of units be multi-threaded (can just schedule 10 parallel threads to read off the queue, etc.). http://gwt-code-reviews.appspot.com/1375802/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
