A small review--larger one coming up tomorrow.
http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/cell/client/ButtonCellBase.java File user/src/com/google/gwt/cell/client/ButtonCellBase.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/cell/client/ButtonCellBase.java#newcode103 user/src/com/google/gwt/cell/client/ButtonCellBase.java:103: ImageResource buttonCellBaseBackground(); Forgot to add buttonCellBaseBackground.png to the review. http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/User.gwt.xml File user/src/com/google/gwt/user/User.gwt.xml (right): http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/User.gwt.xml#newcode55 user/src/com/google/gwt/user/User.gwt.xml:55: <inherits name="com.google.gwt.user.datepicker.DatePicker"/> Can you alphabetize these guys? http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/ButtonBase.java File user/src/com/google/gwt/user/widget/client/ButtonBase.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/ButtonBase.java#newcode56 user/src/com/google/gwt/user/widget/client/ButtonBase.java:56: */ There is another class called com.google.gwt.user.client.ui.ButtonBase and Eclipse loves picking the wrong one just for fun. Is there a way to avoid that name overlap? http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/TextButton.java File user/src/com/google/gwt/user/widget/client/TextButton.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/TextButton.java#newcode25 user/src/com/google/gwt/user/widget/client/TextButton.java:25: * A button that displays text and an option icon. option -> optional http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/TextButton.java#newcode41 user/src/com/google/gwt/user/widget/client/TextButton.java:41: public static TextButton createDefaultTextButton(String value) { Subclasses of TextButton won't like these static methods. Should TextButton just be final? http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/TextButton.java#newcode83 user/src/com/google/gwt/user/widget/client/TextButton.java:83: * Construct a new {@link TextButton}. Need to javadoc this. Probably want to include a hint that users can call createXYZTextButton(), etc. http://gwt-code-reviews.appspot.com/1383806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
