http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/cell/client/ButtonCellBase.java File user/src/com/google/gwt/cell/client/ButtonCellBase.java (right):
http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/cell/client/ButtonCellBase.java#newcode103 user/src/com/google/gwt/cell/client/ButtonCellBase.java:103: ImageResource buttonCellBaseBackground(); On 2011/03/23 03:00:16, pdr wrote:
Forgot to add buttonCellBaseBackground.png to the review.
It didn't upload to rietveld for some reason. Its part of the change though, and I copied it from our existing button styles. We'll brush up the styles before releasing. http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/User.gwt.xml File user/src/com/google/gwt/user/User.gwt.xml (right): http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/User.gwt.xml#newcode55 user/src/com/google/gwt/user/User.gwt.xml:55: <inherits name="com.google.gwt.user.datepicker.DatePicker"/> On 2011/03/23 03:00:16, pdr wrote:
Can you alphabetize these guys?
Done. http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/ButtonBase.java File user/src/com/google/gwt/user/widget/client/ButtonBase.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/ButtonBase.java#newcode56 user/src/com/google/gwt/user/widget/client/ButtonBase.java:56: */ On 2011/03/23 03:00:16, pdr wrote:
There is another class called com.google.gwt.user.client.ui.ButtonBase
and
Eclipse loves picking the wrong one just for fun. Is there a way to
avoid that
name overlap?
I brought this up on the public thread, and most people who commented on this issue said that they are used to duplicate names in Eclipse and would rather we just choose the best name than try to make them unique. Also, only people who extend button will see ButtonBase. Most people will use TextButton. http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/TextButton.java File user/src/com/google/gwt/user/widget/client/TextButton.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/TextButton.java#newcode25 user/src/com/google/gwt/user/widget/client/TextButton.java:25: * A button that displays text and an option icon. On 2011/03/23 03:00:16, pdr wrote:
option -> optional
Done. http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/TextButton.java#newcode41 user/src/com/google/gwt/user/widget/client/TextButton.java:41: public static TextButton createDefaultTextButton(String value) { On 2011/03/23 03:00:16, pdr wrote:
Subclasses of TextButton won't like these static methods. Should
TextButton just
be final?
It seems to work fine. I created TextButton2 (extends TextButton) and included static classes with the same names. No build errors. http://gwt-code-reviews.appspot.com/1383806/diff/3001/user/src/com/google/gwt/user/widget/client/TextButton.java#newcode83 user/src/com/google/gwt/user/widget/client/TextButton.java:83: * Construct a new {@link TextButton}. On 2011/03/23 03:00:16, pdr wrote:
Need to javadoc this. Probably want to include a hint that users can
call
createXYZTextButton(), etc.
Done. http://gwt-code-reviews.appspot.com/1383806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
