http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/cell/client/ButtonCellBase.java File user/src/com/google/gwt/cell/client/ButtonCellBase.java (right):
http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/cell/client/ButtonCellBase.java#newcode53 user/src/com/google/gwt/cell/client/ButtonCellBase.java:53: public static interface Appearance<C> { all interfaces are static, that's noise. Please remove static from all these interfaces http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/cell/client/TextButtonCell.java File user/src/com/google/gwt/cell/client/TextButtonCell.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/cell/client/TextButtonCell.java#newcode71 user/src/com/google/gwt/cell/client/TextButtonCell.java:71: super(SimpleSafeHtmlRenderer.getInstance()); Are you sure that this shared instance of SimpleSafeHtmlRenderer is worth the bother? I wonder about unnecessary clinits and effects on inlining. Did you actually check that SimpleSafeHtmlRenderer.getInstance() is cheaper than new SimpleSafeHtmlRenderer()? http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/user/widget/client/package-info.java File user/src/com/google/gwt/user/widget/client/package-info.java (right): http://gwt-code-reviews.appspot.com/1383806/diff/13/user/src/com/google/gwt/user/widget/client/package-info.java#newcode21 user/src/com/google/gwt/user/widget/client/package-info.java:21: package com.google.gwt.user.widget.client; Any reason not to make this com.google.gwt.widget? http://gwt-code-reviews.appspot.com/1383806/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
