http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/autobean/vm/AutoBeanFactorySource.java
File
user/src/com/google/web/bindery/autobean/vm/AutoBeanFactorySource.java
(right):

http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/autobean/vm/AutoBeanFactorySource.java#newcode32
user/src/com/google/web/bindery/autobean/vm/AutoBeanFactorySource.java:32:
* AutoBeanFactoyModel.
Please put "this is experimental" disclaimer here and in the javadoc of
the other vm packages, along with the package info

http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/autobean/vm/package-info.java
File user/src/com/google/web/bindery/autobean/vm/package-info.java
(right):

http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/autobean/vm/package-info.java#newcode24
user/src/com/google/web/bindery/autobean/vm/package-info.java:24: * @see
com.google.web.bindery.autobean.vm.AutoBeanFactoryMagic
"Magic" is gone, right? Might want to grep for it.

http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java
File
user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java
(right):

http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java#newcode47
user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java:47:
public abstract class AbstractRequestFactoryEditorDriver<R, E extends
Editor<R>>
Hmm. Seems wrong for RequestFactoryEditorDriver to be in bindery. Should
you float another patch to move it back to gwt? Too much work? (I
presume the editors don't belong in bindery, at least not until they
sprout parallel vm implementations.)

http://gwt-code-reviews.appspot.com/1414803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to