Updated the patch, remembering to move the client.impl code into autobean.gwt.client.impl.
http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/autobean/vm/AutoBeanFactorySource.java File user/src/com/google/web/bindery/autobean/vm/AutoBeanFactorySource.java (right): http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/autobean/vm/AutoBeanFactorySource.java#newcode32 user/src/com/google/web/bindery/autobean/vm/AutoBeanFactorySource.java:32: * AutoBeanFactoyModel. On 2011/04/15 00:51:43, rjrjr wrote:
Please put "this is experimental" disclaimer here and in the javadoc
of the
other vm packages, along with the package info
Done. http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/autobean/vm/package-info.java File user/src/com/google/web/bindery/autobean/vm/package-info.java (right): http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/autobean/vm/package-info.java#newcode24 user/src/com/google/web/bindery/autobean/vm/package-info.java:24: * @see com.google.web.bindery.autobean.vm.AutoBeanFactoryMagic On 2011/04/15 00:51:43, rjrjr wrote:
"Magic" is gone, right? Might want to grep for it.
Done. http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java File user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java (right): http://gwt-code-reviews.appspot.com/1414803/diff/1/user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java#newcode47 user/src/com/google/web/bindery/requestfactory/gwt/client/impl/AbstractRequestFactoryEditorDriver.java:47: public abstract class AbstractRequestFactoryEditorDriver<R, E extends Editor<R>> It's in a "gwt" subpackage? It seems weird to put a RequestFactory dependency back in the main com.google.gwt namespace. http://gwt-code-reviews.appspot.com/1414803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
