Nearly there!

http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):

http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode97
user/src/com/google/gwt/uibinder/rebind/FieldManager.java:97: public
void addAttachStatement(String fieldName, String format, Object... args)
Better, but, my point is that all of these methods are redundant with
the FieldWriter api. required should be public and these methods should
be inlined.

http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):

http://gwt-code-reviews.appspot.com/1420804/diff/6001/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode332
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:332: //
change in several files.
Sorry, not okay, this is a really common fail path and you're destroying
our error reporting. Yes, I know it's behind the switch, but still.

Just throw the exception and let your IDE show you where to add the
throws lines. It really won't take that long.

http://gwt-code-reviews.appspot.com/1420804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to