LGTM

http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java
File user/src/com/google/gwt/uibinder/rebind/FieldManager.java (right):

http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode245
user/src/com/google/gwt/uibinder/rebind/FieldManager.java:245: * Gets a
FieldWrite given its name or throws a RuntimeException if not found.
FieldWriteR

http://gwt-code-reviews.appspot.com/1420804/diff/7001/user/src/com/google/gwt/uibinder/rebind/FieldManager.java#newcode251
user/src/com/google/gwt/uibinder/rebind/FieldManager.java:251: if
(fieldWriter == null) {
If you're sure, the RTE is fine. Thanks.

http://gwt-code-reviews.appspot.com/1420804/diff/4003/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
File user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java
(right):

http://gwt-code-reviews.appspot.com/1420804/diff/4003/user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java#newcode318
user/src/com/google/gwt/uibinder/rebind/UiBinderWriter.java:318: * I'm
expliciting over-simplifying this and assuming that the input
intentionally

http://gwt-code-reviews.appspot.com/1420804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to