LGTM (with nits).

Also, the amount of code spent in seemingly trivial adapters for
resources and styles is something I could not fail to notice. Although
this probably not the place to fix it.


http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
File user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java
(right):

http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java#newcode290
user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java:290:
// IE doesn't support innerHtml on a TableSection or Table element, so
we
If this is due to IE behavior, shouldn't this strategy go in
ImplTrident, with a more refined replacement strategy used here? Or may
be explain why generating the whole table is not as bad as it sounds.

http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java#newcode1722
user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java:1722:
private void updateDependsOnSelection() {
The name of this method is now a misnomer as it updates a lot more than
just dependsOnSelection. Same for the javadoc.

http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt/user/cellview/client/CellTable.java
File user/src/com/google/gwt/user/cellview/client/CellTable.java
(right):

http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt/user/cellview/client/CellTable.java#newcode669
user/src/com/google/gwt/user/cellview/client/CellTable.java:669:
super.setColumnWidth(column, width);
Are these overriden methods  necessary? I'd imagine the standard virtual
dispatch in Java would handle this.

http://gwt-code-reviews.appspot.com/1450805/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to