committed as r10228
http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java File user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java (right): http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java#newcode290 user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java:290: // IE doesn't support innerHtml on a TableSection or Table element, so we The comment is misleading. Its important to know if anyone touches the code, but generating a new table makes sense anyway. Setting innerHtml on a Table or TableSection seems more fragile than just wrapping it with a <table> tag, regardless of the browser. On 2011/05/25 23:16:42, rchandia wrote:
If this is due to IE behavior, shouldn't this strategy go in
ImplTrident, with a
more refined replacement strategy used here? Or may be explain why
generating
the whole table is not as bad as it sounds.
http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java#newcode1722 user/src/com/google/gwt/user/cellview/client/AbstractCellTable.java:1722: private void updateDependsOnSelection() { On 2011/05/25 23:16:42, rchandia wrote:
The name of this method is now a misnomer as it updates a lot more
than just
dependsOnSelection. Same for the javadoc.
Done. Renamed to coalesceCellProperties() and updated javadoc. http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt/user/cellview/client/CellTable.java File user/src/com/google/gwt/user/cellview/client/CellTable.java (right): http://gwt-code-reviews.appspot.com/1450805/diff/1/user/src/com/google/gwt/user/cellview/client/CellTable.java#newcode669 user/src/com/google/gwt/user/cellview/client/CellTable.java:669: super.setColumnWidth(column, width); I wanted to update the JavaDoc comments. The additional comment doesn't apply to DataGrid because it always uses fixed layout. I added a note explaining why the methods are overridden. On 2011/05/25 23:16:42, rchandia wrote:
Are these overriden methods necessary? I'd imagine the standard
virtual
dispatch in Java would handle this.
http://gwt-code-reviews.appspot.com/1450805/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
