LGTM w/a couple comments

http://gwt-code-reviews.appspot.com/1461801/diff/9/dev/core/src/com/google/gwt/dev/CompileModule.java
File dev/core/src/com/google/gwt/dev/CompileModule.java (right):

http://gwt-code-reviews.appspot.com/1461801/diff/9/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode217
dev/core/src/com/google/gwt/dev/CompileModule.java:217: if
(alreadyLoadedArchives.contains(archiveURLstring)) {
So is this because a module can be depended on by multiple parent
modules?

http://gwt-code-reviews.appspot.com/1461801/diff/9/dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java
File dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java (right):

http://gwt-code-reviews.appspot.com/1461801/diff/9/dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java#newcode235
dev/core/src/com/google/gwt/dev/cfg/ModuleDefLoader.java:235:
parentLogger.branch(TreeLogger.SPAM, "Module '" + moduleName
maybe don't need this log message at all?

http://gwt-code-reviews.appspot.com/1461801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to