http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java
File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right):

http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcode49
dev/core/src/com/google/gwt/dev/ArchivePreloader.java:49: if
(logger.isLoggable(TreeLogger.TRACE) && archiveURLs != null) {
Nit, but you have a (unneeded?) null check on archiveURLs here but not
on the next for loop.

http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcode57
dev/core/src/com/google/gwt/dev/ArchivePreloader.java:57:
CompilationUnitArchive archive =
CompilationUnitArchive.createFromURL(archiveURL);
Playing around with this patch in DevMode, it looks like User.gwtar is
loaded from disk each time I hit refresh. Is this necessary or could
CompilationStateBuilder remember which archiveURLs it has already loaded
to avoid deserializing User.gwtar each time?

http://gwt-code-reviews.appspot.com/1461801/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to