I moved a method to get the timestamp from a resource referenced by a URL from AbstractClientBundleGenerator I wanted to use in CompileModule and moved it.
http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java File dev/core/src/com/google/gwt/dev/ArchivePreloader.java (right): http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcode44 dev/core/src/com/google/gwt/dev/ArchivePreloader.java:44: logger.log(TreeLogger.TRACE, "Looking for precompiled archives. To disable, use -Dgwt.usearchives=false"); On 2011/06/16 19:08:36, tobyr wrote:
100 chars
Done. http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcode49 dev/core/src/com/google/gwt/dev/ArchivePreloader.java:49: if (logger.isLoggable(TreeLogger.TRACE) && archiveURLs != null) { On 2011/06/17 05:16:16, stephenh wrote:
Nit, but you have a (unneeded?) null check on archiveURLs here but not
on the
next for loop.
Done. http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/ArchivePreloader.java#newcode57 dev/core/src/com/google/gwt/dev/ArchivePreloader.java:57: CompilationUnitArchive archive = CompilationUnitArchive.createFromURL(archiveURL); On 2011/06/17 05:16:16, stephenh wrote:
Playing around with this patch in DevMode, it looks like User.gwtar is
loaded
from disk each time I hit refresh. Is this necessary or could CompilationStateBuilder remember which archiveURLs it has already
loaded to
avoid deserializing User.gwtar each time?
If the .gwtar is coming out of a .jar file , it is certainly a waste of time (since these files are read from classpath). I added a freshness check. http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java File dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java (right): http://gwt-code-reviews.appspot.com/1461801/diff/4002/dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java#newcode493 dev/core/src/com/google/gwt/dev/cfg/ModuleDefSchema.java:493: TreeLogger branch = logger.branch(TreeLogger.DEBUG, On 2011/06/16 19:08:36, tobyr wrote:
Why is this log even needed? We log from ModuleDefLoader.nestedLoad.
Removed. http://gwt-code-reviews.appspot.com/1461801/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
