http://gwt-code-reviews.appspot.com/1464803/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java
File dev/core/src/com/google/gwt/dev/CompileModule.java (right):

http://gwt-code-reviews.appspot.com/1464803/diff/1/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode189
dev/core/src/com/google/gwt/dev/CompileModule.java:189: Set<String>
alreadyLoadedArchives = new HashSet<String>();
So, this change is essentially moving the set of archived units to be
global for a specific set of modules passed in.  I see that this will
reduce the amount of work needed for a specific set of modules.
However, what about the case where you then have a different overlapping
set of modules.  This could then cause more work there, since the second
set may see that it needs to compile units that previously would have
been included in the subset of modules that are shared between the 2
sets, etc....

http://gwt-code-reviews.appspot.com/1464803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to