http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java File dev/core/src/com/google/gwt/dev/CompileModule.java (right):
http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode211 dev/core/src/com/google/gwt/dev/CompileModule.java:211: // written out. On 2011/06/23 16:50:31, tobyr wrote:
Should NOT be written out?
Done. http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode251 dev/core/src/com/google/gwt/dev/CompileModule.java:251: for (CompilationUnit unit : archive.getUnits().values()) { On 2011/06/23 16:50:31, tobyr wrote:
I think you want to drop this for loop, by changing the above
declaration to:
Set<String> archivedUnits = new
HashSet<String>(archive.getUnits().values()); Unfortunately, I'm not adding the units themselves, I'm adding the getResourcePath() value from each one. http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode282 dev/core/src/com/google/gwt/dev/CompileModule.java:282: CompilationUnitArchive outputModule = new CompilationUnitArchive(moduleToCompile); On 2011/06/23 16:50:31, tobyr wrote:
Not from this patch, but I think this would be more clear if it were
named
moduleArchive.
see if you like the new name I gave it. http://gwt-code-reviews.appspot.com/1464803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
