LGTM w/very minor nit

http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java
File dev/core/src/com/google/gwt/dev/CompileModule.java (right):

http://gwt-code-reviews.appspot.com/1464803/diff/5/dev/core/src/com/google/gwt/dev/CompileModule.java#newcode234
dev/core/src/com/google/gwt/dev/CompileModule.java:234: if (unitPaths !=
null) {
Oh right, got it.  Just a nit, but how about some naming to
disambiguate.  We have "unitsInArchive" which is global to all modules,
and we have "alreadyArchivedUnits" which is only per module scope.  How
about:

currentModuleArchivedUnits

http://gwt-code-reviews.appspot.com/1464803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to