I was able to recreate the stack overflow with type variables as simple
as <T extends Enum<T>>.  The latest patch addresses this and I've
changed the error-handling code to trap Throwables to fail better.


http://gwt-code-reviews.appspot.com/1467804/diff/1028/user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
File
user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java
(right):

http://gwt-code-reviews.appspot.com/1467804/diff/1028/user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java#newcode111
user/src/com/google/web/bindery/requestfactory/apt/ClientToDomainMapper.java:111:
// Here, t would be NONE or PACKAGE, neither of which make sense
On 2011/06/28 22:17:00, tbroyer wrote:
s/t/x/

Done.

http://gwt-code-reviews.appspot.com/1467804/diff/6052/user/src/com/google/web/bindery/requestfactory/apt/DomainChecker.java
File
user/src/com/google/web/bindery/requestfactory/apt/DomainChecker.java
(right):

http://gwt-code-reviews.appspot.com/1467804/diff/6052/user/src/com/google/web/bindery/requestfactory/apt/DomainChecker.java#newcode340
user/src/com/google/web/bindery/requestfactory/apt/DomainChecker.java:340:
state.warn(warnTo, "Cannot validate method (%s.%s) because the domain
mapping for the"
This is more verbose, but it will unambiguously identify the unchecked
method in question.

http://gwt-code-reviews.appspot.com/1467804/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to