On Fri, Jul 1, 2011 at 5:52 PM, <[email protected]> wrote:
> Regarding the generics issue, I agree that the checker is behaving
> correctly: the List<SubFooProxy> would be converted to a List<SubFoo>
> when being checked against the domain type. A List<? extends BaseFoo>
> can't be assigned to the type List<SubFoo> since the list might contain
> OtherFoo elements.
>
> Since we've mainly be talking about edge-case details of the
> implementation and it sounds like the checker mostly works with your
> code base, I'm going to go ahead and check the code in with some
> error-reporting fixes to make it less spammy when compiling with javac.
> The findFoo() error is changed to a warning, although I'm thinking that
> it might be better for the novice user if it's an error. For the
> advanced user, an annotation processor option could be used to switch
> that from an error to a warning.
I totally agree: go ahead, check it in!
Better than an option would be distinct @SuppressWarnings values (such
as a @SuppressWarnings("requestfactory.noFinder")), but I don't know
how they work, even less if that's possible at all.
And if you feel better with an error, no problem, I'll add a locator
with a throwing find() and create() to make sure they don't go
client-to-server. I'm so happy I could remove my horrendous hacks in
ServiceLayerDecorators once RFIV will be removed!
> I'll be on vacation the early part of next week and will be studiously
> avoiding the computer. Thanks for your feedback, it's been very
> helpful.
You're welcome. You made (and still makes) such great work with RF and
editors (and everything else) that I had to do it in return as a thank
you.
Have great vacations!
--
Thomas Broyer
/tɔ.ma.bʁwa.je/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
