http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java File dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java (right):
http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java#newcode21 dev/core/src/com/google/gwt/dev/jjs/ast/AccessModifiers.java:21: public enum AccessModifiers { I'll second Eric's concern here. But that not-withstanding, I'd suggest the name of this enum should be singular, e.g., "AccessModifier". Since you can't compose multiple modifiers in a single instance, it appears misleading when you declare it as a param to a method, e.g. myFunc(AccessModifiers access).... http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/JConstructor.java File dev/core/src/com/google/gwt/dev/jjs/ast/JConstructor.java (right): http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/ast/JConstructor.java#newcode53 dev/core/src/com/google/gwt/dev/jjs/ast/JConstructor.java:53: // Access only matters for virtual methods, just use public. Maybe make a different enum constant for this case, for clarity? Or if the AccessModifier is only relevant for virtual methods, maybe change that to VirtualMethodAccessModifier, and allow it to be null, or maybe NON_VIRTUAL for non-virtual methods. I suppose the only place it matters currently is when output is generated with ToStringGenerationVisitor (just for debugging clarity). http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java File dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java (right): http://gwt-code-reviews.appspot.com/1470803/diff/19/dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java#newcode728 dev/core/src/com/google/gwt/dev/jjs/impl/UnifyAst.java:728: for (JMethod upref : collected.get(method.getSignature())) { debug cruft? http://gwt-code-reviews.appspot.com/1470803/ -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
