On 2012/05/14 19:09:11, rdayal wrote:
Had to roll this back. These are the test failures that I'm seeing:
1)
testValueObjectCreateSetRetrieveUpdateViaList(com.google.web.bindery.requestfactory.gwt.client.RequestFactoryTest)java.lang.RuntimeException:
Remote test failed at 127.0.0.1 / Mozilla/5.0 (X11; U; Linux i686
(x86_64);
en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Caused by: junit.framework.AssertionFailedError: expected: <2>,
actual: <1>
at
com.google.web.bindery.requestfactory.gwt.client.RequestFactoryTest.onSuccess(RequestFactoryTest.java:2622)
at
com.google.web.bindery.requestfactory.gwt.client.RequestFactoryTest.onSuccess(RequestFactoryTest.java:1)
at
com.google.web.bindery.requestfactory.shared.impl.AbstractRequest.onSuccess(AbstractRequest.java:129)
at
com.google.web.bindery.requestfactory.shared.impl.AbstractRequestContext.processPayload(AbstractRequestContext.java:377)
... 28 more
2)
testValueObjectCreateSetRetrieveUpdateViaList(com.google.web.bindery.requestfactory.gwt.client.RequestFactoryExceptionHandlerTest)java.lang.RuntimeException:
Remote test failed at 127.0.0.1 / Mozilla/5.0 (X11; U; Linux i686
(x86_64);
en-US; rv:1.9.1.2) Gecko/20090729 Firefox/3.5.2
Caused by: junit.framework.AssertionFailedError: expected: <2>,
actual: <1>
at
com.google.web.bindery.requestfactory.gwt.client.RequestFactoryTest.onSuccess(RequestFactoryTest.java:2622)
at
com.google.web.bindery.requestfactory.gwt.client.RequestFactoryTest.onSuccess(RequestFactoryTest.java:1)
at
com.google.web.bindery.requestfactory.shared.impl.AbstractRequest.onSuccess(AbstractRequest.java:129)
at
com.google.web.bindery.requestfactory.shared.impl.AbstractRequestContext.processPayload(AbstractRequestContext.java:377)
... 28 more
Are you seeing the same thing?
Yes.
The culprit here is the test (or the harness, depending on your PoV):
SimpleFoo#setSimpleValues(List) actually only stores the first value
from the passed-in list, so after the persist() returns,
getSimpleValues() only contains a single value.
I remember I had many iterations where I tweaked these, and it seems
like I forgot to commit them or something like that.
I've added a List field to SimpleFoo so setSimpleValues stores the list.
That property was only ever used in this test [1] so it doesn't break
other tests (I've run RequestFactorySuite).
[1] at least for now, issue 1601806 adds a call the setter in one of the
tests, but it uses a singletonList as an argument, and never checks
getSimpleValues.
http://gwt-code-reviews.appspot.com/1622803/
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
