LGTM. Going to run this back through the battery of tests.


http://gwt-code-reviews.appspot.com/1622803/diff/6001/user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java
File
user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java
(left):

http://gwt-code-reviews.appspot.com/1622803/diff/6001/user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java#oldcode858
user/test/com/google/web/bindery/requestfactory/server/SimpleFoo.java:858:
public void setSimpleValues(List<SimpleValue> simpleValueField) {
How odd and confusing that the setter would just set the first
entry....I know it's just for testing code, but it makes it tricky for
other people to use SimpleFoo for their unit testing..

Anyway, good catch.

http://gwt-code-reviews.appspot.com/1622803/

--
http://groups.google.com/group/Google-Web-Toolkit-Contributors

Reply via email to