On Tue, May 29, 2012 at 9:27 AM, <[email protected]> wrote: > If you call nextId twice, isn't it being incremented in each case > (meaning the values would differ between different calls)? You're only > creating DefaultProxyStore once, right? Or is your point that it's > unclear as to whether or not nextId is unique for a given Proxy, > regardless of the DefaultProxyStore instance that is backing it?
The problem was that the nextId field wasn't being included in the serialized form of the DefaultProxyStore class, so it would be lost after a serialize/deserialize round trip (in the new instance), and then the same id could be allocated twice. (I haven't looked at the latest patch yet.) In practice, this would only be a problem if you allocate more than one id per map entry. But there's nothing in ProxyStore's API specification that says you can't do that. - Brian -- http://groups.google.com/group/Google-Web-Toolkit-Contributors
