Goktug Gokdogan has posted comments on this change.
Change subject: Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
......................................................................
Patch Set 1:
(6 comments)
....................................................
Commit Message
Line 9: Also this enables unit test frameworks to set an uncaught exception
handler without interfering with the user/production one. A following patch
will make the changes necessary to utilize new
GWT#setUncaughtExceptionHandlerForTest.
Done
....................................................
File user/src/com/google/gwt/core/client/GWT.java
Line 180: * callbacks, timers, and RPC.
There was not longer uncaught exception handling in DOM.dispatch event so
I'm putting a reference to com.google.gwt.core.client.impl.Impl.
Line 184: public static void reportUncaughtException(Throwable t) {
Done.
Hopefully, I will introduce the one that always report in the next patch,
in that case we can use method name reportUncaughtException..
Line 188: if (uncaughtExceptionHandlerForTest != null) {
Done.
I changed the order. I'm not sure the other one carries the weight of added
complexity.
Also as now on, we will be in the control of exception reporting, we can do
add similar changes later.
Line 299: public static void setUncaughtExceptionHandlerForTest(
This is public in the sense as developers can set it to null to disable
exception reporting to the test frameworks.
....................................................
File user/src/com/google/gwt/core/client/impl/AsyncFragmentLoader.java
Line 3: *
I can revert them. Are you referring to this specific CL or in general?
Eclipse doesn't give the option to remove trailing spaces just for edited
lines. When that feature it is not enabled, it becomes pretty painful to do
it manually.
Also this is usually fixes trailing spaces just in the comments so that was
the reason I didn't mind much.
--
To view, visit https://gwt-review.googlesource.com/1820
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
