Brian Slesinsky has posted comments on this change.
Change subject: Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
......................................................................
Patch Set 1:
(1 comment)
....................................................
File user/src/com/google/gwt/core/client/GWT.java
Line 299: public static void setUncaughtExceptionHandlerForTest(
That makes sense, but I don't think this is the right API for that use case.
In production code, the uncaughtExceptionHandlerForTest field should not be
used at all so it will compile away. So I think this method doesn't belong
in a non-testing public API, particularly a very visible one like "GWT".
In a test, if there's a reason to disable the test's exception handler
(which should be rare), it seems like it's more readable if it happens in
gwtSetUp() or the test method itself, so someone reading the test knows
that there's something special going on.
So it seems like there should be a private API for GWTTestCase to use, and
we should add a protected method to GWTTestCase itself to disable its
default exception handling?
--
To view, visit https://gwt-review.googlesource.com/1820
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
