Goktug Gokdogan has posted comments on this change.
Change subject: Introduces GWT#reportUncaughtException and
GWT#setUncaughtExceptionHandlerForTest.
......................................................................
Patch Set 2:
(3 comments)
....................................................
File user/src/com/google/gwt/core/client/GWT.java
Line 187: uncaughtExceptionHandler.onUncaughtException(t);
Yes, good catch. There is actually a test would fail with this error but
was not part of this patch :(
Line 189: if (uncaughtExceptionHandler != null) {
Intentionally "if" as I want to the same code flow for both unit tests and
production.
Originally I tried writing a version of this method that was doing exactly
what you are suggesting but I noticed that in a lot places that approach
was causing a lot of complexity and refactoring to handle it properly as
they are written in a way to swallow the exceptions.
Also code pieces that re-throw the exception is actually following a more
complex logic right now; they are not actually catching the exception in
the first place.
My plan is to turn this method into a reportUncaughtException which will
make the exception to escape to browser in a deferred when there is no
uncaught exception handler but hope will not break the code flow.
Line 301: UncaughtExceptionHandler uncaughtHandler) {
Done
--
To view, visit https://gwt-review.googlesource.com/1820
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I7c25b8de334ef24c4795efdbb76023e0825136bb
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
