Matthew Dempsky has posted comments on this change.
Change subject: Added gwt.codeserver.port parameter to RemoteServiceServlet
......................................................................
Patch Set 1: Code-Review+1
(2 comments)
LGTM, just minor nits.
....................................................
File user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java
Line 172: if (port >= 0) {
Also check <= 65535?
Line 184: + " expected integer but got: " + value);
Maybe "expected integer between 0 and 65535 but got"?
--
To view, visit https://gwt-review.googlesource.com/2341
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf2366cb94297e738cf50bb9d8038fef66b89722
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
