Goktug Gokdogan has posted comments on this change.
Change subject: Added gwt.codeserver.port system property to
RemoteServiceServlet
......................................................................
Patch Set 4:
(3 comments)
....................................................
File user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java
Line 123: new SerializationPolicyClient(5000, 5000);
If you don't use constants for these numbers, then it will be difficult for
reader to understand which number is for which one and also what are the
units (e.g. is it seconds or milliseconds?).
....................................................
File user/src/com/google/gwt/user/server/rpc/SerializationPolicyClient.java
Line 36: SerializationPolicyClient(int connectTimeout, int readTimeout) {
Can you document the unit for the timeouts? I think even renaming
fields/parameters is ok (e.g. connectionTimeoutInMs).
Line 82: logger.logInfo("downloaded serialization policy from " +
sourceName);
nit: perhaps you might want to keep the first letter upper case in log
messages.
--
To view, visit https://gwt-review.googlesource.com/2341
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf2366cb94297e738cf50bb9d8038fef66b89722
Gerrit-PatchSet: 4
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
