Brian Slesinsky has posted comments on this change.
Change subject: Added gwt.codeserver.port system property to
RemoteServiceServlet
......................................................................
Patch Set 2:
(13 comments)
....................................................
File
user/src/com/google/gwt/user/server/rpc/DefaultSerializationPolicyClient.java
Line 48: conn.setConnectTimeout(5000);
Done (as a constant for the whole configuration)
Line 51:
((HttpURLConnection)conn).setInstanceFollowRedirects(false);
Done
....................................................
File user/src/com/google/gwt/user/server/rpc/RemoteServiceServlet.java
Line 42: implements SerializationPolicyProvider,
DefaultSerializationPolicyClient.Logger {
Done
Line 136: * will be attempted.)
The comments are getting a bit repetitive so I'll leave that as a usage
search.
Line 175: private int getCodeServerPort(ServletConfig config) throws
ServletException {
Done
Line 332: * in the same ServletContext as this servlet. If no policy is
found, it then attempts to
Done
Line 333: * load the policy from the URL returned by {@link
#getCodeServerPolicyUrl}.</p>
Done
Line 349: return policy;
If we attempt to use the code server and it's not running, there will be a
delay until it times out. This shouldn't happen for normal requests, so
it's better to check locally for a serialization policy first.
I wouldn't mind falling back to the code server only when the policy isn't
found, but that would require changing the API on the
loadSerializationPolicy() method and I don't think I want to do that quite
yet.
Line 363: * <p>By default, returns null. If the
<i>gwt.codeserver.port</i> servlet parameter is set,
Done
Line 364: * returns a URL under <tt>http://localhost:{port}</tt>.</p>
Done
Line 367: * @return the policy, or null if not available.
Done
Line 369: protected String getCodeServerPolicyUrl(String strongName) {
I wanted to make it possible to use a code server that's not on localhost
without making it too easy (since there are security implications). Added
javadoc.
Line 383: protected SerializationPolicyClient getCodeServerClient() {
Simplified. I was thinking of reusing the HTTP client for google3-specific
code that doesn't use RemoteServiceServlet, but that can wait for another
CL.
--
To view, visit https://gwt-review.googlesource.com/2341
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Iaf2366cb94297e738cf50bb9d8038fef66b89722
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Matthew Dempsky <[email protected]>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
