Matthew Dempsky has posted comments on this change.

Change subject: Ugrade JDT to 3.8.3.
......................................................................


Patch Set 1:

(1 comment)

....................................................
File dev/core/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java
Line 24: import com.google.gwt.dev.util.collect.HashMap;
I agree with Thomas. We should benchmark if it doesn't make a measurable difference, we should get rid of the customization if that's the only reason for us to have this file.

I expect by now more time has been spent optimizing the JDK's HashMap than has been spent on com.google.gwt.dev.util.collect.HashMap. :)


--
To view, visit https://gwt-review.googlesource.com/2361
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to