Matthew Dempsky has posted comments on this change.

Change subject: Ugrade JDT to 3.8.3.
......................................................................


Patch Set 1:

(1 comment)

....................................................
Commit Message
Line 9: Fixed an error in RequestFactory that resulted in a class implementing a generic interface twice with I think I'm getting lost in the generics, but it sounds like you understand and agree with the change. :)

My only concern then is whether this change could break user code somehow, but it sounds like it's technically wrong already.

Roberto, can you split the RequestFactory changes into a separate CL/review that we land first?


--
To view, visit https://gwt-review.googlesource.com/2361
To unsubscribe, visit https://gwt-review.googlesource.com/settings

Gerrit-MessageType: comment
Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes

--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
--- You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email 
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.


Reply via email to