Roberto Lublinerman has posted comments on this change.
Change subject: Ugrade JDT to 3.8.3.
......................................................................
Patch Set 1:
(6 comments)
....................................................
Commit Message
Line 9: Fixed an error in RequestFactory that resulted in a class
implementing a generic interface twice with
Done
....................................................
File dev/build.xml
Line 60: <include
name="eclipse/jdtCompilerAdapter-3.8.3.v20130121-145325.jar" /> <!--
extracted from eclipse/org.eclipse.jdt.core_3.8.3.v20130121-145325.jar -->
Done
Line 110: <zipfileset
src="${gwt.tools.lib}/eclipse/jdtCompilerAdapter-3.8.3.v20130121-145325.jar"
/> <!-- extracted from
eclipse/org.eclipse.jdt.core_3.8.3.v20130121-145325.jar -->
I am not sure. It is inside the jdt.core jar as a jar file. By having it
extracted its contents will be included.
....................................................
File dev/core/src/com/google/gwt/dev/javac/JavaSourceParser.java
Line 84: while ((idx = separatorIdx(className)) >= 0) {
Java 7 now has different signatures for inner classes when the outer class
is generic. E.g. for
class Outer<A> {
class Inner {
}
}
the signature used to by L...Outer$Inner and now is L...Outer<TA;>.Inner
My mistake it does not apply to binary class names. Reverted.
Line 196: options.originalSourceLevel = options.sourceLevel =
ClassFileConstants.JDK1_6;
Done
....................................................
File
dev/core/src/org/eclipse/jdt/internal/compiler/lookup/SourceTypeBinding.java
Line 24: import com.google.gwt.dev.util.collect.HashMap;
I'll run some experiments and let you know the results.
--
To view, visit https://gwt-review.googlesource.com/2361
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If7d533adcb953de614ea071cfd7e57560b664ce0
Gerrit-PatchSet: 1
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Brian Slesinsky <skybr...@google.com>
Gerrit-Reviewer: Matthew Dempsky <mdemp...@google.com>
Gerrit-Reviewer: Ray Cromwell <cromwell...@google.com>
Gerrit-Reviewer: Roberto Lublinerman <rlu...@google.com>
Gerrit-Reviewer: Thomas Broyer <t.bro...@gmail.com>
Gerrit-HasComments: Yes
--
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "Google Web Toolkit Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to google-web-toolkit-contributors+unsubscr...@googlegroups.com.
For more options, visit https://groups.google.com/groups/opt_out.
