Goktug Gokdogan has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
......................................................................
Patch Set 2:
Basically it would be preferable for anyone to use the subpixel variants
always when either measuring elements or doing pixel perfect
positioning. Since we cannot change the current return values of the DOM
methods we need a equally convenient way of using the subpixel values so
people will prefer using them instead. If we hide them behind a cast
people will still continue to use the round values and hit problems
which we are seeing today.
I disagree that this will make them to prefer the new API. If they know it,
they will use it no matter where they are defined. If they don't know the
deal, they will not use it.
I also disagree it is inconvenient. If you do pixel calculations then you
will very likely need to do multiple calls and each call needs to be done
against the subpixel APIs. In that case you can get the subpixel API and do
multiple calls against it without mistakenly doing a mix and match between
old and new APIs.
Putting aside all of these; if we really want people to use the newer APIs,
we should really consider converting previous APIs to double for 3.0.
--
To view, visit https://gwt-review.googlesource.com/3090
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27e98f0ad3c1c236b2d85d24f197719fa4cd352a
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos <[email protected]>
Gerrit-Reviewer: Artur Signell <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: John Ahlroos <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
