Jens Nehlmeier has posted comments on this change.
Change subject: Ensures integer pixel values and adds getters for subpixel
values
......................................................................
Patch Set 2:
Maybe we should just split this CL up into two. The first one actually
fixes issue 6113 by truncating possible float values to int so that no GWT
app breaks by surprise (e.g. GWT-RPC serializers). This CL could then land
in 2.6.
The second CL will land in GWT 3.0. Here we just take the current API and
convert them to double (breaking change). By the time GWT 3.0 will be
released browsers possibly have also catched up to actually render sub
pixels correctly. Take a look at
https://bug63336.bugzilla.mozilla.org/attachment.cgi?id=114574 with
different browsers and resize the window slowly. In most browsers you will
see 1px gaps appearing/disappearing and this is just pure CSS without any
JS calculations and without any zoom. Once they managed it to render sub
pixels correctly then its probably also a good time to convert the current
API for accessing sub pixel coordinates.
This would also have the added benefit that we don't have to deprecate
anything. If we add both APIs now I am pretty sure in the future when every
browser actually does use sub pixels and renders them correctly we would
deprecate the current integer based API because no one really uses it
anymore.
--
To view, visit https://gwt-review.googlesource.com/3090
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: I27e98f0ad3c1c236b2d85d24f197719fa4cd352a
Gerrit-PatchSet: 2
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: John Ahlroos <[email protected]>
Gerrit-Reviewer: Artur Signell <[email protected]>
Gerrit-Reviewer: Brian Slesinsky <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Jens Nehlmeier <[email protected]>
Gerrit-Reviewer: John A. Tamplin <[email protected]>
Gerrit-Reviewer: John Ahlroos <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Ray Cromwell <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
