> I'd like to submit a CL that moves the IsButton, IsListBox, etc. Okay, I think this CL is at a pretty good state and ready for high-level comments:
https://gwt-review.googlesource.com/#/c/3231 I have most of the common widgets covered, but not all--e.g. the older panels I haven't used yet, so I had not made interfaces for. Probably the two main discussion points would be: 1) I added a new characteristic interface, HasStyle, that both IsElement and IsWidget extend. This allows helper methods that hide/show/etc. things via CSS to take either a widget or an element. To me this is helpful, but it does technically introduce some new APIs (Element.addStyleName) vs. just making interfaces for existing methods. I can take this out if it really rubs people the wrong way. 2) I haven't added any javadocs to the interfaces--not sure the best approach here. If the interfaces were included from day 1, I believe the "meaty" javadocs would be in the interface, and the widget javadocs would just be pointers, e.g. "See javadoc in the IsXxx#method interface". But that would be a lot of work to move all of those over, and today users are used to the javadocs in the widgets themselves anyway, so I don't think we should move them. But having absolutely no javadocs in the interfaces is probably not good either--any suggestions? Just a token "See javadocs in the widget"? With a specific "@link" to the widget implementation? That may take awhile, but is something I could slog through... - Stephen -- http://groups.google.com/group/Google-Web-Toolkit-Contributors --- You received this message because you are subscribed to the Google Groups "GWT Contributors" group. To unsubscribe from this group and stop receiving emails from it, send an email to [email protected]. For more options, visit https://groups.google.com/groups/opt_out.
