Colin Alworth has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
......................................................................
Patch Set 6: Code-Review+1
Nope, we can work with it - a wrapper isn't really an option, since we get
real benefit from getting static methods that look like instance ones
without the mess of static imports or new-ing up instances that wrap the
original elt just long enough to run a method on them and gc them (unless
the compiler now can unwrap that single final field and method and treat it
as if it were static to begin with?). We used to have a great big flyweight
thing going on to avoid the extra object creation, but move to extending
Element to avoid that little extra cost...
My main point was to bring it up as a point to discuss, to make sure that
adding a new final method to a non-final class was deliberate. GXT is happy
to plan ahead and remove it before 2.6 lands (and thanks for the heads up
on toggleClassName), and move to something else in the meantime, we'd just
rather not make a habit of that, cutting new specific gxt minor releases to
accommodate specific gwt minor releases, and I'm sure we're not alone in
that.
--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy <[email protected]>
Gerrit-Reviewer: Colin Alworth <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
