Goktug Gokdogan has posted comments on this change.
Change subject: Add hasClassName method in com.google.gwt.dom.client.Element
......................................................................
Patch Set 6:
What I was saying is that your overridden getElement will return GxtElement
as before that only provides single method called gxt. So the new interface
is not superfluous, it basically provides you a namespace for your
extension methods. So your users will need to do
getElement().gxt().hasClassName()
instead of
getElement().hasClassName()
Of course another alternative is to have a different method in your base
widget:
getGxtElement().hasClassName()
where GxtElement will be like before without extending Element but
delegates to original Element. It can also provide getElement for cases
where GWT element is expected.
Anyway, you probably already know these alternatives. My point was; it is
generally a risky approach to extend GWT JSOs and you might want to
re-evaluate that.
--
To view, visit https://gwt-review.googlesource.com/3070
To unsubscribe, visit https://gwt-review.googlesource.com/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: Ia09567b8c58cac02f8126c33ef169b26def3d19c
Gerrit-PatchSet: 6
Gerrit-Project: gwt
Gerrit-Branch: master
Gerrit-Owner: Andrey Korzhevskiy <[email protected]>
Gerrit-Reviewer: Colin Alworth <[email protected]>
Gerrit-Reviewer: Daniel Kurka <[email protected]>
Gerrit-Reviewer: Goktug Gokdogan <[email protected]>
Gerrit-Reviewer: Leeroy Jenkins <[email protected]>
Gerrit-Reviewer: Stephen Haberman <[email protected]>
Gerrit-Reviewer: Thomas Broyer <[email protected]>
Gerrit-HasComments: No
--
http://groups.google.com/group/Google-Web-Toolkit-Contributors
---
You received this message because you are subscribed to the Google Groups "GWT Contributors" group.
To unsubscribe from this group and stop receiving emails from it, send an email
to [email protected].
For more options, visit https://groups.google.com/groups/opt_out.
